DIB Engine : passing all tests
mike.kaplinskiy at gmail.com
Thu May 28 18:32:51 CDT 2009
On Thu, May 28, 2009 at 6:58 PM, Jerome Leclanche <adys.wh at gmail.com> wrote:
> Hi Max,
> From what I understand, the problem is not your design. I don't want
> to put words in anyone's mouth, but to me it seems you and AJ agree on
> the final goal; Alexandre just doesn't want the "intermediary step" in
> the master tree (there could be many reasons for this).
> As you said, starting the move to gdi32 right now would be a huge
> waste of time (in maintenance and more), and prone to hell-knows how
> many regressions. You should get the DIB engine uploaded to its own
> repo or wine-hacks (http://repo.or.cz/w/wine/hacks.git).
> It's also been mentioned, but getting some documentation up and
> running on the wiki would be of great help. Maybe the authors of the
> previous DIB engine attempts could also give a shot at helping with
> that. People will also want (need) to know what they should test, how
> to test it, where to give feedback, what's still in the works, ...
> You've done a great job so far, here's hoping it gets sorted :)
> On Thu, May 28, 2009 at 10:46 PM, Steven Edwards <winehacker at gmail.com> wrote:
>> On Thu, May 28, 2009 at 2:20 PM, Massimo Del Fedele <max at veneto.com> wrote:
>>> IMHO, and really "in my opinion", loosing time to integrate it inside gdi32
>>> whithout proper guidelines would be crazy. I mean, I'd never do it :-)
>>> The intermediate step was made (among other reasons) to check if the
>>> upcoming driver had the chance to be accepted.
>>> Moving it *now* inside gdi32 would mean a big loss of time with almost no
>>> hopes to see it in mainstream, added to the above effort of keeping it
>>> in sync with changing gdi32.
>>> OTOH, if winedib would be embedded as-is or with some minor mods, I could
>>> od course take the job of moving it stepwise into gdi32.
>> It seems to me the best course is keep developing it outside of the
>> tree until the remaining glitches are resolved and then try to
>> resubmit it by moving in to gdi32. At least if Alexandre still wants
>> to reject it due to remaining design issues, we have a good enough
>> Steven Edwards
>> "There is one thing stronger than all the armies in the world, and
>> that is an idea whose time has come." - Victor Hugo
> Jerome Leclanche
I completely agree with Jerome, and would like to add that tests of
the DIB engine would probably be accepted into the tree. Since Max
knows the finer notches of the DIB engine, taking the time to write
some tests would seem to be a good idea - both to speed up the future
migration and to make sure we're not missing any quirks. It may also
help pinpoint certain bugs within the implementation.
More information about the wine-devel