ntdll: implement FLG_HEAP_ENABLE_TAIL_CHECK

Dan Kegel dank at kegel.com
Wed Nov 18 16:28:07 CST 2009


On Wed, Nov 18, 2009 at 12:47 PM, Eric Pouech <eric.pouech at orange.fr> wrote:
> interesting stuff
> however, you don't handle correctly HeapReAlloc(..., ZERO_MEMORY,...) calls
> when the already allocated block grows in place

Thanks for catching that.
I decided to start over and push the tail fill down into the heap
routines rather than try to put it in a wrapper; the extra
abstraction wasn't helping.
Here's a second try, this time only for large arenas, but
with valgrind integration working.  (It also has a workaround for
a strange valgrind problem that leaves an empty variable in
the environment that confuses wine.)

This time around, the only test that fails with WINE_GLOBAL_FLAG=0x10
is comctl32/dpa.c, and I could well imagine that might have a real problem
lurking.

Now to tackle the small arena case...
- Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: large.patch
Type: text/x-patch
Size: 12088 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20091118/69c7610b/attachment-0001.bin>


More information about the wine-devel mailing list