Whitespace cleanups

Francois Gouget fgouget at free.fr
Thu Nov 26 10:15:19 CST 2009


On Wed, 25 Nov 2009, Ken Thomases wrote:
[...]
> One important reason to avoid whitespace-only changes is it makes 
> git-blame essentially useless for finding the real source of 
> functional changes.

Such changes don't make git-blame useless. They just make it a bit 
harder to use.

Let's say your 'git-blame dlls/mshtml/tests/dom.c' leads you to commit 
1e4412d7 which, by looking at it, you decide is a false positive. Then 
you do:

   $ git cat-file -p 1e4412d7
   tree ea3b2e117b383ade8afc7cc9bf534c48faf891c7
   parent 44f520a5b6f2bd6ec6da8793177711e57bda9c72
   author Francois Gouget <fgouget at free.fr> 1258539107 +0100
   committer Alexandre Julliard <julliard at winehq.org> 1258553736 +0100

   mshtml/tests: Add a trailing '\n' to ok() calls.

Then you run git-blame again:

   git blame 44f520a5 dlls/mshtml/tests/dom.c

And continue the analysis until you find the right culprit.

-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
    I haven't lost my mind, it's backed up on tape around here somewhere...



More information about the wine-devel mailing list