[4/5] WineD3D: SetRenderTarget bypasses stateblock recording

Stefan Dösinger stefan at codeweavers.com
Fri Oct 2 03:53:51 CDT 2009


Am 02.10.2009 um 10:44 schrieb Henri Verbeet:

> 2009/10/1 Stefan Dösinger <stefan at codeweavers.com>:
>> +        /* Finally, reset the viewport as the MSDN states. Tests  
>> show that stateblock recording is ignored.
>> +         * the change goes directly into the primary stateblock.
>> +         */
>> +        This->stateBlock->viewport.Height = ((IWineD3DSurfaceImpl  
>> *)This->render_targets[0])->currentDesc.Height;
>> +        This->stateBlock->viewport.Width  = ((IWineD3DSurfaceImpl  
>> *)This->render_targets[0])->currentDesc.Width;
>
> I know you wrote tests for this, could you please submit those as
> well? "pRenderTarget" should work just as well as
> "This->render_targets[0]".
I haven't yet figured out how the stateblock event test machine works,  
I wanted to hold off the test until I get them properly integrated,  
and fix the bug in the meantime(since we already know what the correct  
behavior is)




More information about the wine-devel mailing list