[ntdll] Move file attribute logic to new function DIR_get_attributes()

Dan Kegel dank at kegel.com
Tue Oct 6 19:33:48 CDT 2009

On Sun, Oct 4, 2009 at 9:21 AM, Juan Lang <juan.lang at gmail.com> wrote:
> +    TRACE("fd %d, name %s, attrib %x\n", fd, debugstr_a(unix_fname), *pattrib);
> +    *pattrib = attributes;
> Any reason you're tracing *pattrib before you set it?

Fixed, thanks!

> + * If unix_fname is not NULL, DIR_is_hidden_file is called to do .dotfile check
> This is a change from the existing code, and I don't know whether it's
> intended or not:...
> Neither this case, nor the FileAllInformation case, were checking
> show_dot_files before.

I'm still not, as in those two cases, unix_fname is NULL.

> Also, I'm not sure if this is a useful comment or not, but patch 2/3
> is the hardest to review... it seems possible to
> break this one up further.

Done, you bastard :-)  I agree, that should be easier to review.

Ready for another look (see latest four attachments to
http://bugs.winehq.org/show_bug.cgi?id=15679 )


More information about the wine-devel mailing list