[1/2] oleaut32/tests: Testcase for IPicture_Render with icons, check for drawing size and position

Wilfried Pasquazzo wilfried.pasquazzo at gmail.com
Fri Oct 16 04:55:46 CDT 2009


2009/10/16 Paul Vriens <paul.vriens.wine at gmail.com>:
> On 10/14/2009 07:08 PM, Wilfried Pasquazzo wrote:
>>
>> Yet another testcase+fix for a regression introduced
>> by one of my previous patches.
>>
>> ---
>> [1/2] oleaut32/tests: ...
>>
>> modified files: oleaut32/tests/olepicture.c
>>
>> Draws a icon and checks if it is scaled and positioned correctly.
>> Windows XP passes all tests.
>> Wine fails at the scaling test (marked with todo_wine).
>> ---
>> [2/2] oleaut32: ...
>>
>> modified files: oleaut32/olepicture.c
>> modified files: oleaut32/tests/olepicture.c
>>
>> Fix for Wine scaling of Icons when drawing.
>> Wine now passes the previously implemented scaling test.
>> todo_wine of scaling test removed.
>>
>> Fixes Bug: http://bugs.winehq.org/show_bug.cgi?id=20365
>>
>> Note: I didn't remove the FIXME-Message, because this
>> implementation seems still not completely right. It does only allow
>> to draw the whole icon, because it ignores the src width and height
>> parameters. However it worked well like this for over 8 years and
>> it is very unlikely that any real application will want to draw only a
>> part of an icon.
>> ---
>>
>>
>> Wilfried Pasquazzo
>>
>
> Hi Wilfried,
>
> This patch causes test failures on NT4 and lower:
>
> http://test.winehq.org/data/tests/oleaut32:olepicture.html
>
> Could you have a look?
>
> --
> Cheers,
>
> Paul.
>

Of course, thanks for notifying me. I'll modify the test to fix that.



More information about the wine-devel mailing list