[PATCH 5] winmm/tests: Add MCI waveaudio tests.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Mon Oct 26 10:44:19 CDT 2009


Hi,

> +/* Some tests hang or crash Wine. Enable once fixed. */
> +#define FULL_TEST 0

>Please don't introduce dead code. If the tests really can't work then
>don't add them at all until you have the corresponding fixes.

Will do.  Although I'd very much prefer having tests than no tests.
I've been fixing MCI regressions that were as old as 2001 that would
hopefully not have occured if there had been tests in the first place.
The #if FULL_TEST is very useful when compiling on MS-W* to immediately
spot what Wine should eventually do, and as direction for others
when I'll be gone.

How do other people deal with that situation?
 - use some patch manager, e.g. quilt?
 - maintain seprate test files for running under MS-W*?
 - ignore, write no tests and wait for bugs.winehq?
 - ...?

Regards,
 Jörg Höhle
PS: despite my 20 patches to MCI, there's still need for #if !FULL_TEST.



More information about the wine-devel mailing list