Nate Gallaher : msi: Add tablename tracking to VIEW_find_column

[Dan Kegel]

On Sat, Oct 31, 2009 at 8:02 AM, Nathan Gallaher
<ngallaher at deepthought.org> wrote:
> Could someone give me a pointer as to how you reproduce this trace?  I've
> spent some time fiddling with valgrind, the WINETEST_WRAPPER env var, and
> --enable-maintainer-mode, all to no avail.

I use
http://code.google.com/p/winezeug/source/browse/trunk/valgrind/valgrind-daily.sh
but you can more simply do

wine notepad &
cd dlls/msi/tests
valgrind --trace-children=yes --track-origins=yes wine msi_test.exe.so db.c

Today that finds one valgrind error:

==21129== Conditional jump or move depends on uninitialised value(s)
==21129==    at 0xCD6B96A: RtlFreeHeap (heap.c:1460)
==21129==    by 0xD700437: msi_free (msipriv.h:1099)
==21129==    by 0xD70051F: VIEW_find_column (msiquery.c:82)
==21129==    by 0xD714479: SELECT_AddColumn (select.c:392)
==21129==    by 0xD71466F: SELECT_CreateView (select.c:436)
==21129==    by 0xD6F07CD: INSERT_CreateView (insert.c:393)
==21129==    by 0xD72D4B6: sql_parse (sql.y:149)
==21129==    by 0xD72ED6A: MSI_ParseSQL (sql.y:960)
==21129==    by 0xD70083C: MSI_DatabaseOpenViewW (msiquery.c:137)
==21129==    by 0xD700C90: MsiDatabaseOpenViewW (msiquery.c:279)
==21129==    by 0xD70060F: MsiDatabaseOpenViewA (msiquery.c:110)
==21129==    by 0xD541575: test_streamtable (db.c:1443)
==21129==  Uninitialised value was created by a stack allocation
==21129==    at 0xD700443: VIEW_find_column (msiquery.c:60)

If you also want to see memory leaks, add --leak-check=full
- Dan