[PATCH 3/7] comctl32/monthcal: Use a single calendar for hittesting tests, make point calculation at runtime

Nikolay Sivov bunglehead at gmail.com
Wed Sep 30 05:10:11 CDT 2009

Paul Vriens wrote:
> On 09/29/2009 12:36 PM, Nikolay Sivov wrote:
>> Changelog:
>>     - be sure we have a single view calendar for hittesting
>> ------------------------------------------------------------------------
> Hi Nikolay,
> This one introduces a test failure on several platforms:
> monthcal.c:1002: Test failed: Expected 10000, got 10002
> I fixed it on my NT4 box by checking the point more to the left (see 
> attached).
> I somehow doubt it's the correct fix though. Aren't these tests with 
> more-or-less fixed points error-prone (aka, locale/font/dpi dependent)?
Hi, Paul.

I certainly noticed that. A problem for me is that it doesn't fail on 
mine XP. Could you please send me (offlist) a crossbuilt binary with 
this patch - I'm not able to built it myself at the moment.

About fragility of these test - it was a reason why I use dynamic point 
calculation here, it was fixed before. So now it should be less dpi/font 
dependent I hope. It isn't affected by locale too much I think.

More information about the wine-devel mailing list