winedump: code cleanup

Mikhail Maroukhine mikolg at yandex.ru
Fri Apr 2 10:49:34 CDT 2010


oops.
Absolutely agree.
Thanks for the comment. Will fix it.

Thanks,
Mikhail

On Fri, 02 Apr 2010 00:29:16 +0700, Alexandre Julliard  
<julliard at winehq.org> wrote:

> "Mikhail Maroukhine" <mikolg at yandex.ru> writes:
>
>> Hello,
>>
>> Could you clear a little what do you mean under "stop abusing"?
>> I've removed incorrect usage of constness in declaration for the
>> variable that is changed for sure.
>> I've send "try 2" patch with additional correction and extended log
>> message.
>
> I mean your new origProtoRef variable (which BTW uses a completely
> different naming convention from the rest of the function) to work
> around the fact that the argument is modified. Much better to use a
> properly named local variable to store results and not modify the
> argument.
>


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/



More information about the wine-devel mailing list