[PATCH] user32: honor bfOffBits in BITMAP_Load

Dmitry Timoshkov dmitry at codeweavers.com
Tue Apr 6 08:56:37 CDT 2010


Wolfram Sang <wolfram at the-dreams.de> wrote:

> +        offbits = bmfh->bfOffBits - sizeof(BITMAPFILEHEADER);

> +    bits = (char *)info + (offbits ?: size);

The purpose of offbits is not clear. Besides "?:" is absolutely not readable,
putting an explicit 0 there would help a bit. Adding a test case wouldn't hurt
either.

-- 
Dmitry.



More information about the wine-devel mailing list