[PATCH] user32: honor bfOffBits in BITMAP_Load
Wolfram Sang
wolfram at the-dreams.de
Tue Apr 6 09:42:16 CDT 2010
Dmitry Timoshkov wrote:
> Wolfram Sang <wolfram at the-dreams.de> wrote:
>
>> + offbits = bmfh->bfOffBits - sizeof(BITMAPFILEHEADER);
>
>> + bits = (char *)info + (offbits ?: size);
>
> The purpose of offbits is not clear.
It has the same purpose as 'offbits' in
BmpFrameDecode_ReadUncompressed() from bmpdecode.c. And in bfOffBits,
too. Please give me a hint, I still think it is clear this way.
> Besides "?:" is absolutely not readable,
> putting an explicit 0 there would help a bit.
:D Okay, that proves your point. This is a short from for 'offbits ?
offbits : size'. Will fix that.
> Adding a test case wouldn't hurt either.
Hmm, do you have a pointer for a test verifying how something should
look like (in contrast to checking a return value)? Was this not
necessary for LoadImage() in general?
Regards,
Wolfram
More information about the wine-devel
mailing list