[PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests

Christian Costa titan.costa at wanadoo.fr
Mon Apr 19 13:26:01 CDT 2010


Henri Verbeet a écrit :
> On 19 April 2010 09:43, Christian Costa <titan.costa at wanadoo.fr> wrote:
>   
>> +BOOL is_pow2(UINT num)
>> +{
>> +    UINT i;
>> +
>> +    if (!num) return FALSE;
>> +    for (i = 0; num >> 1; i++) num >>= 1;
>> +
>> +    return (num << i) == num;
>> +}
>>     
> This should at least be static. You can also just replace it with
> "return !(num & (num - 1));". You don't care about 0, since you
> already check that earlier in D3DXCheckTextureRequirements().
> make_pow2() can probably be simplified as well.
>
>
>   
make_pow2 can be simplified a bit but there will still be some iterations.






More information about the wine-devel mailing list