[5/5] shdocvw: Recurse into directories when adding Favorites

Alexandre Julliard julliard at winehq.org
Mon Aug 2 06:54:38 CDT 2010


Alexander Nicolaysen Sørnes <alex at thehandofagony.com> writes:

> @@ -109,10 +109,10 @@ static void add_fav_to_menu(HMENU menu, LPWSTR title, LPCWSTR url)
>  {
>      MENUITEMINFOW item;
>      /* Subtract the number of standard elements in the Favorites menu */
> -    INT favcount = GetMenuItemCount(menu) - 2;
> +    static INT favcount;
>      LPWSTR urlbuf;

The previous version was better, you don't want a static variable for
this, you may want to do it multiple times, or the menu may get changed
somewhere else.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list