[PATCH 07/10] explorerframe/nstc: Implement Initialize.

Alexandre Julliard julliard at winehq.org
Mon Aug 2 08:36:37 CDT 2010

David Hedberg <david.hedberg at gmail.com> writes:

> +    /* Native accepts a NULL prc, so should we. */
> +    if(prc)
> +        SetWindowPos(This->hwnd_main, HWND_TOP, prc->left, prc->top,
> +                     prc->right - prc->left, prc->bottom - prc->top, SWP_SHOWWINDOW);

It would be better to create it directly with the correct rectangle.
Also SWP_SHOWWINDOW is not useful since the window is created
visible. And please don't add comments like "native does this", that
should be true of pretty much anything we do. Native behavior should be
documented by test cases anyway, not comments.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list