[PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

Ricardo Filipe ricardojdfilipe at gmail.com
Mon Aug 2 17:53:05 CDT 2010


2010/8/2 Jeff Cook <jeff at deserettechnology.com>:
> What compiler are you running? It works fine for me and I don't see
> any errors or warnings.
>
> On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard <julliard at winehq.org> wrote:
>> Jeff Cook <jeff at deserettechnology.com> writes:
>>
>>> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer)
>>>      for (id = 0; id < mmixer->chans; ++id)
>>>      {
>>>          line *mline = &mmixer->lines[id];
>>> +        if (!mline->elem)
>>> +        {
>>> +            break;
>>> +        }
>>>          int ofs = CONTROLSPERLINE * id;
>>
>> You can't do that:
>>
>> mixer.c: In function ‘fillcontrols’:
>> mixer.c:252: error: ISO C90 forbids mixed declarations and code
>>
>> --
>> Alexandre Julliard
>> julliard at winehq.org
>>
>
>
>

it's not compiler related. you can't mix variable declarations with
code in C90 standard. just move that check to the end of all variable
declarations and it'll be fine.



More information about the wine-devel mailing list