[PATCH 2/2 (resend)] shell32: Also compare UNIX realpaths in SHChangeNotify

Alexandre Julliard julliard at winehq.org
Wed Aug 4 05:24:14 CDT 2010


Andrew Eikum <aeikum at codeweavers.com> writes:

> This fixes bug 18606.
>
> It's possible to refer to the same file in two different ways with PIDLs
> in Wine.  This can cause notifications via SHChangeNotify to fail to
> trigger.  To ensure an apples-to-apples comparison, we convert the
> incoming PIDLs and the filters to UNIX paths and compare those if the
> PIDLs fail to match.

You should never compare Unix paths. If you want to compare file
identity you should use stat and compare device+inode. But it's not
clear to me that this is the right thing to do here, what is the exact
case that is failing?

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list