Re: Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)
Oldrich Jedlicka
oldium.pro at seznam.cz
Wed Aug 4 06:29:43 CDT 2010
Hi Stefan,
4.8.2010 13:04:43, Stefan Dösinger <stefandoesinger at gmx.at>:
>
> Am 04.08.2010 um 12:29 schrieb Alexandre Julliard:
>
> > Oldřich Jedlička <oldium.pro at seznam.cz> writes:
> >
> >> + __TRY
> >> + {
> >> + hr = IDirectDraw_CreateSurface(lpDD, NULL, &surf, NULL);
> >> + todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface
> didn't return 0x%08x, but 0x%08x\n",
> >> + DDERR_INVALIDPARAMS, hr);
> >> + }
> >> + __EXCEPT_PAGE_FAULT
> >> + {
> >> + todo_wine ok(FALSE, "IDirectDraw_CreateSurface dereferenced NULL
> pointer\n");
> >> + }
> >> + __ENDTRY
> >
> > You can't use Wine exception macros in tests.
> In this case it is better not to include the NULL pointer tests in this patch
> and add them in the patch that adds the NULL pointer checks in ddraw.
Ok, otherwise there would be a page fault in the test, which is not good. I will send updated patchset in the evening.
Oldřich.
> @Alexandre: I didn't know about that either, otherwise I'd have caught it when
> looking at the patch.
More information about the wine-devel
mailing list