Request for comments - d3dx9: Add tests for FVF <-> declaration conversion.

[Stefan Dösinger]

Hi,
The tests look OK. Since a part of the code was taken from dlls/d3d9/tests/vertexdeclaration.c(which is OK) you should copy the copyright lines along as well.

Am 10.08.2010 um 23:25 schrieb misha680:

> 
> Dear All:
> 
> I have become more busy with schoolwork than I had imagined.
> 
> However, I would still like, if possible, to finish work on
> http://bugs.winehq.org/show_bug.cgi?id=22918
> 
> It has been suggested that I send patches to the wine-devel list first for
> feedback. This way, I hope to be able to get developer expertise in these
> areas, and to be able to understand exactly what is necessary for a given
> patch.
> 
> I have, per this comment from Henri:
> http://bugs.winehq.org/show_bug.cgi?id=22918#c51
> written a draft patch for FVF <-> declaration conversion tests.
> 
> It can be found at the Nabble link below. I will appreciate comments as to
> what is necessary for this patch (or a similar one) to get accepted.
> http://wine.1045685.n5.nabble.com/file/n2471306/0001-d3dx9-Add-tests-for-FVF-declaration-conversion.txt
> 0001-d3dx9-Add-tests-for-FVF-declaration-conversion.txt 
> 
> I realize there are already three tests for conversion in one direction. I
> have decided at the moment to leave those as is and focus on getting
> necessary feedback for getting an appropriate patch accepted. If you have
> any guidance with regards to this, much appreciated.
> 
> Thank you
> Misha
> 
> p.s. I have uploaded some shell scripts that I use for Wine development
> here:
> http://groups.google.com/group/misha680-wine/files
> I don't know how useful they will be to anyone else, but if anything, it
> provides an nice backup for my computer.
> -- 
> View this message in context: http://wine.1045685.n5.nabble.com/Request-for-comments-d3dx9-Add-tests-for-FVF-declaration-conversion-tp2471306p2471306.html
> Sent from the Wine - Devel mailing list archive at Nabble.com.
> 
>