[PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance.

Vitaliy Margolen wine-devel at kievinfo.com
Wed Aug 11 23:23:34 CDT 2010


On 08/11/2010 09:14 PM, Austin Lund wrote:
> On 11 August 2010 20:12, David Adam<david.adam.cnrs at gmail.com>  wrote:
> I wasn't sure of the best way to do this.  But basically I want to
> check that the Vtbl had been set.  I cannot cast to
> IDirectMusicPortImpl and I'm still confused by the COM macros.

You shouldn't be checking for any vtbl, it's all object's internal stuff. If 
you must check a pointer if it's null or not, then do that explicitly. 
Pointers have different size in 32-bit and 64-bit architectures.

Also you don't need two things pointing to one another. IDirectMusicPort is 
a pointer in a first place. So no need for memset either. And no need for 
all the extra traces that print the same stuff. You already checking if it's 
null or not. The value of the pointer won't be of any use.

Vitaliy.



More information about the wine-devel mailing list