[PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)

Vitaliy Margolen wine-devel at kievinfo.com
Wed Aug 11 23:32:18 CDT 2010


On 08/11/2010 08:58 PM, Austin Lund wrote:
>
>
> +static BOOL test_InitAudio(void)
> +{
> +    hr = IDirectMusicPerformance8_InitAudio(idmusicperformance,NULL,&pDirectSound,NULL,1,128,0x3f,NULL);
> +    if (hr != S_OK) return FALSE;
> +    else return TRUE;
> +}

Please put spaces after comas, as you do in the rest of the file.

What are those magic numbers? Please use constants. If they are missing, add 
them to appropriate header file first.

Same thing with return as in prior function..

> +static void test_PChannelInfo(void)
Already covered in another thread.

Vitaliy.



More information about the wine-devel mailing list