[PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)
Austin Lund
austin.lund at gmail.com
Thu Aug 12 00:16:58 CDT 2010
On 12 August 2010 14:32, Vitaliy Margolen <wine-devel at kievinfo.com> wrote:
>
> What are those magic numbers? Please use constants. If they are missing, add
> them to appropriate header file first.
They are the numbers passed to the InitAudio method from bug 22598.
I've seen quite a few places where "magic" numbers are used in tests
with no references. I thought it would be ok to start the test off
this way.
What is the best way to resubmit for another round of review? To
wine-patches again (try 3)? Or on wine-devel? Or something else.
More information about the wine-devel
mailing list