[PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)
wine-devel at kievinfo.com
Thu Aug 12 00:36:27 CDT 2010
On 08/11/2010 11:16 PM, Austin Lund wrote:
> On 12 August 2010 14:32, Vitaliy Margolen<wine-devel at kievinfo.com> wrote:
>> What are those magic numbers? Please use constants. If they are missing, add
>> them to appropriate header file first.
> They are the numbers passed to the InitAudio method from bug 22598.
1 is DMUS_APATH_SHARED_STEREOPLUSREVERB, 0x3f is DMUS_AUDIOF_ALL.
> I've seen quite a few places where "magic" numbers are used in tests
> with no references. I thought it would be ok to start the test off
> this way.
If they are a defined constant it's not a good thing to have them even in
tests. Of course you won't have a constant for for things like 128 in your
test (which is a number of performance channels).
> What is the best way to resubmit for another round of review? To
> wine-patches again (try 3)? Or on wine-devel? Or something else.
Send to wine-patches, as long as you have all the problems fixed. Just wait
a day to see if anyone else has any additional questions.
More information about the wine-devel