shdocvw: Remove useless menu separator
Alexander Nicolaysen Sørnes
alex at thehandofagony.com
Tue Aug 17 08:19:02 CDT 2010
Tirsdag 17 august 2010 01:42:21 skrev Frédéric Delanoy :
> On Mon, Aug 16, 2010 at 23:28, Octavian Voicu <octavian.voicu at gmail.com>
> > Not sure if it's useless. I thing it's intended to separate the static
> > part of the menu (Add to favorites) from the dynamically generated
> > list of favorite items that follows (which isn't implemented yet).
> In that case, shouldn't the menu separator also be auto-generated when
> the list of (>=1) favorite items is generated?
> How about when there's no favorite at all?
> Separators should only be used to separate non-empty "sections" IMO;
> otherwise they just look out of place.
Ideally, there would be a single grayed menu item with the text "(empty)"
after the separator if no Favorites are present. This would should users where
they are supposed to find favorites, and is also what native IE does.
Anyway, I think this patch should be discarded.
More information about the wine-devel