[PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer

Mariusz Pluciński vshader at gmail.com
Wed Aug 18 11:53:33 CDT 2010


W dniu 18.08.2010 18:28, Andrew Eikum pisze:
>> This result is strange, cause routine modified by this patch (called
>> test_add_remove_game ) is not even called on these operating systems -
>> and test added by my previous patch demonstrates it (and it succeeded).
>> Did I something wrong? I cannot imagine how it could fail when previous
>> test was succeeded.
>
> You can see the error message dialog in the screenshots on the testbot
> result webpage. In this case, you've got missing exports,
> ConvertSidToSidStringW and RegGetValueW. Some solutions are to make
> those into function pointers (and skip appropriately if they're
> missing), use the A versions if they exist, or use a different function
> that exists on more platforms.
>
> Andrew
>
I understand. Thank you very much for the explanation. I did not know, 
that new code can interfere in any way on systems where it is never called.

W dniu 18.08.2010 18:33, Vincent Povirk pisze:
> Oh.
>
> Personally, I would ignore failures on operating systems<  Vista,
> since gameux won't be present and the tests would not normally be run.
>
OK, I'll see if my patch is accepted despite of these results. If not, 
I'll modify it, to make it calling these routines through pointers.



More information about the wine-devel mailing list