gdi32: Properly set ERROR_NOACCESS when GetObject receives invalid arguments

Jerome Leclanche adys.wh at gmail.com
Thu Aug 19 18:33:28 CDT 2010


That's what I was going for originally, but AJ on IRC deemed it not necessary.


J. Leclanche



On Fri, Aug 20, 2010 at 12:27 AM, Octavian Voicu
<octavian.voicu at gmail.com> wrote:
> On Thu, Aug 19, 2010 at 4:56 PM, Jerome Leclanche <adys.wh at gmail.com> wrote:
>> Broken programs will crash on wine if they, for example, pass
>> arguments to GetObject in the wrong order.
>> This fixes bug #18864.
>
>> +        if (buffer && ((ULONG_PTR)buffer >> 16) == 0)
>
> Wouldn't a __TRY ... __EXCEPT_PAGE_FAULT be better / safer?
>
> Octavian
>
>
>



More information about the wine-devel mailing list