Fwd: [PATCH 1/3] winmm: Fix mciSendString command parsing on 64-bit.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Fri Aug 27 08:30:07 CDT 2010


Octavian,

>I just looked in mmddk.h and they have this:
>#define MCI_INTEGER64  13

It's good you found out about MCI_INTEGER64. Yet it's completely crazy because
googling it yields 6 hits in total, all about Wine bug 22146.
Bing shows nothing at all. How can such a name be that invisible?

>So, do you want to fix your patches and send them, or do you want me
>to continue working on this patch set?
I'm fine if you do (as I've plenty of other patches in my queue) especially
if you also fix the parser to handle MCI_HWND (another DWORD_PTR),
which is the second half needed for 64bit as I mention in
http://bugs.winehq.org/show_bug.cgi?id=22146#c12

GetDWORD also needs some change to be able to parse DWORD_PTR things,
e.g. window handles. I've not yet written a single test for that (no mciavi tests).
I'll send you all the MCI tests I have written ASAP.

Even without written tests, one can use WINEDEBUG=+mci and analyse the parser logs
for individual commands sent e.g. via the interactive MCI shell you'll find in
http://bugs.winehq.org/show_bug.cgi?id=20232#c10

You obviously own a 64bit system so it's easier for you to test. I don't and had to beg.

Regards,
 Jörg Höhle



More information about the wine-devel mailing list