[PATCH 4/6] winealsa.drv: Append hw address to handle to prevent name collision. (resend)

Jeff Cook jeff at deserettechnology.com
Sun Aug 29 01:43:13 CDT 2010


On Tue, Aug 3, 2010 at 7:49 AM, Vitaliy Margolen
<wine-devel at kievinfo.com> wrote:
>> +    memcpy(ww->ds_desc.szDesc, description,
>> +            min( (sizeof(ww->ds_desc.szDesc) - 1), strlen(description))
>> );
>
> This does not guarantee that ww->ds_desc.szDesc will be \0 terminated.
>
> Vitaliy.
>
What do you want me to do? This looks pretty safe to me and I just
copied the block from elsewhere and replaced the variables. Do you
want me to manually read to the end of ww->ds_desc.szDesc and replace
with a \0? Sorry for the noobness.

From
Jeff



More information about the wine-devel mailing list