[1/2] msi: Don't try to install or remove ODBC drivers if the component is disabled.

Hans Leidekker hans at codeweavers.com
Thu Dec 9 10:25:23 CST 2010

On Thu, 2010-12-09 at 07:52 -0800, Joris Huizer wrote:

>  I noticed in this patch, exactly the same lines are added in all the
>  functions; wouldn't it be better to add a(n) (inline) function
>  isComponentEnabled(rec,package) to reduce the repetition?

I'm not opposed to consolidating the check in a function, but note that
there's a trace in there that reveals the action being run (through the
function name), and this information should not get lost.

More information about the wine-devel mailing list