sound issues (which are not cared since 1.3.1)

wylda at volny.cz wylda at volny.cz
Sat Dec 25 16:22:48 CST 2010


Hi guys,

there are bug reports showing random crashes with audio on, during
winecfg etc. I was bit by those too... There is probably something
wrong how regressions are handled here, which goes on and thus there
are unneeded bugreports which cost everyone's time to read,
evaluate, search, mark, retest... Why don't you use revert more
offen like kernel guys?


Back to the sound issue - my zero programming skill standing just on
sound despair, i guess in dlls/winealsa.drv/mixer.c ALSA_MixerInit()
should be

int card, err, capcontrols=0

otherwise things like:

mixdev[mixnum].chans += capcontrols;

mixdev[mixnum].lines = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
sizeof(line) * mixdev[mixnum].chans);

mixdev[mixnum].controls = HeapAlloc(GetProcessHeap(),
HEAP_ZERO_MEMORY, sizeof(control) *
CONTROLSPERLINE*mixdev[mixnum].chans);


goes crazy like in http://bugs.winehq.org/show_bug.cgi?id=25231#c2.
Could someone review this piece of code, please?


Thanks,
W.





More information about the wine-devel mailing list