mshtml: COM cleanup for the IHTMLWindow2 iface.

Jacek Caban jacek at codeweavers.com
Mon Dec 27 06:16:35 CST 2010


On 12/27/10 12:50 PM, Michael Stefaniuc wrote:
> ---
> Jacek, I don't like the usage of impl_from_IHTMLWindow2() in
> HTMLWindow_invoke() as that isn't a method of the IHTMLWindow2 vtbl. Can
> you please cross check that and clean it up if necessary?

That's fine itself, the IUnknown passed there is defined by HTMLWindow 
object and it's IHTMLWindow2 iface in this case. However it can be done 
better and we can avoid this particular impl_from_IHTMLWindow2 call. I 
will send a patch after your patch will be in Git.

Thanks,
     Jacek




More information about the wine-devel mailing list