dwmapi: add a stub for DwmDefWindowProc

Austin English austinenglish at gmail.com
Mon Feb 1 04:24:30 CST 2010


On Mon, Feb 1, 2010 at 4:10 AM, Reece Dunn <msclrhd at googlemail.com> wrote:
> On 1 February 2010 04:35, Austin English <austinenglish at gmail.com> wrote:
>
> + BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam,
> LPARAM lParam, LRESULT *plResult)
>
> Minor nitpick here -- there is a space before the BOOL return type.

Fixed.

> +{
> +    FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg);
> +
> +    return E_NOTIMPL;
>
> But more importantly, you are returning a HRESULT instead of a BOOL
> return value. MSDN
> (http://msdn.microsoft.com/en-us/library/aa969507%28VS.85%29.aspx)
> says that it is a BOOL and should return FALSE if the message was not
> handled.

Ah, good point. Yeah, was still a bit tired when I sent that
one....the FIXME was wrong too, which is also corrected here.


-- 
-Austin
-------------- next part --------------
diff --git a/dlls/dwmapi/dwmapi.spec b/dlls/dwmapi/dwmapi.spec
index 7c613d0..a5082d4 100644
--- a/dlls/dwmapi/dwmapi.spec
+++ b/dlls/dwmapi/dwmapi.spec
@@ -21,7 +21,7 @@
 120 stub @
 
 @ stub DwmAttachMilContent
-@ stub DwmDefWindowProc
+@ stdcall DwmDefWindowProc(ptr long ptr ptr ptr)
 @ stub DwmDetachMilContent
 @ stub DwmEnableBlurBehindWindow
 @ stdcall DwmEnableMMCSS(long)
diff --git a/dlls/dwmapi/dwmapi_main.c b/dlls/dwmapi/dwmapi_main.c
index 6042028..57c7c31 100644
--- a/dlls/dwmapi/dwmapi_main.c
+++ b/dlls/dwmapi/dwmapi_main.c
@@ -159,3 +159,13 @@ HRESULT WINAPI DwmGetGraphicsStreamTransformHint(UINT uIndex, MilMatrix3x2D *pTr
 
     return E_NOTIMPL;
 }
+
+/**********************************************************************
+ *           DwmDefWindowProc         (DWMAPI.@)
+ */
+BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, LRESULT *plResult)
+{
+    FIXME("(%p, %d, %lx, %lx, %p) stub\n", hwnd, msg, wParam, lParam, plResult);
+
+    return FALSE;
+}


More information about the wine-devel mailing list