[PATCH 4/5] d3drm: Add some tests

Christian Costa titan.costa at wanadoo.fr
Mon Feb 1 15:10:23 CST 2010


Paul Vriens a écrit :
>
> On 02/01/2010 08:56 AM, Stefan Dösinger wrote:
>> On Monday 01 February 2010 08:18:42 Christian Costa wrote:
>>> +void Test(void)
>>> +{
>>> ...
>>> Test();
>> I think the function name Test() won't be too helpful once more tests 
>> are
>> added. You can also make it static, unless you plan to call it from 
>> another .c
>> file.
>>
>>
>
> +#define D3DRM_GET_PROC(func) \
> +    p ## func = (void*)GetProcAddress(d3drm_handle, #func); \
> +    if(!p ## func) { \
> +      trace("GetProcAddress(%s) failed\n", #func); \
>
> A win_skip() would probably be better here.
>
> +      FreeLibrary(d3drm_handle); \
> +      return FALSE; \
> +    }
> +
> +static BOOL InitFunctionPtrs(void)
> +{
> +    d3drm_handle = LoadLibraryA("d3drm.dll");
> +
> +    if(!d3drm_handle)
> +    {
> +        skip("Could not load d3drm.dll\n");
>
> And here as well.
>
Well. It comes from vector.c. I never use win_skip so far but I can take 
a look at it. Thanks.





More information about the wine-devel mailing list