[PATCH 1/5] qedit: Mostly stubbed out implementation of SampleGrabber filter
Nikolay Sivov
bunglehead at gmail.com
Tue Feb 2 07:30:20 CST 2010
On 2/2/2010 16:21, Paul Chitescu wrote:
> Changelog:
> qedit: Mostly stubbed out implementation of SampleGrabber filter
>
> Until the last patch component is applied most application will crash as they
> rarely check for errors.
>
> + if (IsEqualIID(riid,&IID_IUnknown) ||
> + IsEqualIID(riid,&IID_IPersist) ||
> + IsEqualIID(riid,&IID_IMediaFilter) ||
> + IsEqualIID(riid,&IID_IBaseFilter)) {
> + InterlockedIncrement(&This->refCount);
> + *ppvObject =&(This->IBaseFilter_Vtbl);
> + return S_OK;
> + }
>
You should use ISampleGrabber_AddRef() here on success to keep increment
call in one place.
It's a common practice as far as i can see in Wine code.
More information about the wine-devel
mailing list