[PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend)

Paul Vriens paul.vriens.wine at gmail.com
Fri Feb 12 06:16:11 CST 2010

On 02/12/2010 12:39 PM, Ilya Basin wrote:
> Thanks for review. Not sending to wine-patches this time. New patch is
> in the bottom. What's better, to attach a generated patch or to use it
> as a message body?

Depends on your mail client I guess. I usually attach but there are 
others who inline.

> PV>  Why is this necessary?
> /* ensure tmpdir is in %TEMP%: GetTempPath() can succeed even if TEMP is undefined */

But do your tests actually rely on %TEMP% being defined? Not having a 
TEMP (or TMP) will probably makes loads of tests fail and I doubt one 
has a valid config without those.

Also when you sent a newer patch that has changes you should mark it as 
'try x' instead of 'resend'. 'Resend' is used when you think the patch 
has been missed by AJ for example.



More information about the wine-devel mailing list