Use GCC's -Wlogical-op if possible

[Austin English]

On Sun, Jan 3, 2010 at 4:13 AM, Gerald Pfeifer <gerald at pfeifer.com> wrote:
> On Tue, 23 Jun 2009, Paul Vriens wrote:
>>> For those interested, here's the make log in Monday's git. 94 warnings
>>> for me.
>> Sent 3 patches based on your log.
>>
>> I have less (55) warnings on 4.3.2 btw, but most look like false positives.
>
> On my FreeBSD test system I am see no warnings triggered by -Wlogical-op
> any more.  How does it look on your side?

ole32:
usrmarshal.c:485: warning: logical ‘&&’ with non-zero constant will
always evaluate as true
usrmarshal.c:1098: warning: logical ‘&&’ with non-zero constant will
always evaluate as true
usrmarshal.c:1290: warning: logical ‘&&’ with non-zero constant will
always evaluate as true

oleaut32:
variant.c:2090: warning: logical ‘||’ with non-zero constant will
always evaluate as true
variant.c:2090: warning: logical ‘&&’ with non-zero constant will
always evaluate as true

comctl32/tests:
tab.c:520: warning: logical ‘&&’ with non-zero constant will always
evaluate as true
tab.c:540: warning: logical ‘&&’ with non-zero constant will always
evaluate as true
tab.c:563: warning: logical ‘&&’ with non-zero constant will always
evaluate as true
tab.c:978: warning: logical ‘&&’ with non-zero constant will always
evaluate as true

kernel32/tests:
atom.c:70: warning: logical ‘||’ with non-zero constant will always
evaluate as true

-- 
-Austin