Use GCC's -Wlogical-op if possible

André Hentschel nerv at
Mon Jan 4 10:28:32 CST 2010

Gerald Pfeifer schrieb:
> I had a patch for this one (comctl32/tests) which I received feedback on 
> and need to brush up.  I should be able to do so coming week.  Anybody 
> volunteering to look into the other ones?
>> kernel32/tests:
>> atom.c:70: warning: logical ?||? with non-zero constant will always
>> evaluate as true
> Gerald

I dont see a reason to take that warning serious, as its not a problem in any case. in kernel32 it just  happens because we use a Macro. Taking that case(v==1) out of the Macro leads to harder readable code.
So IMHO i would not make -Wlogical-op the default.


Best Regards, André Hentschel

More information about the wine-devel mailing list