[PATCH] Don't generate FIXME warnings for DllCanUnloadNow.
m.b.lankhorst at gmail.com
Wed Jan 6 09:03:15 CST 2010
Reece Dunn schreef:
> NOTE: Some of the DllCanUnloadNow functions always return S_OK. I
> intend to address that in a separate patch once I have investigated
> whether the DLLs implement COM objects or not.
When a dll is first implemented it probably returns S_OK since no
interfaces were used yet, but some programs just depended on the dll
being present. However the FIXME should not be removed then, since if it
does implement interfaces and it gets freed while in use this can be a
serious crash. I'd rather have that message then as a red flag for
investigation. Returning nothing in case of S_FALSE is fine though, but
a TRACE() would still be nice there just in case.
More information about the wine-devel