Patch feedback requested for OleCreatePropertyFrame()

Rob Shearman robertshearman at
Fri Jan 8 05:36:09 CST 2010

2010/1/8 Wolfram Sang <wolfram at>:
> Geoffrey Hausheer wrote:
>> Would someone mind reviewing this for style/content?  I still have no
> Can't say much about the content, but stylewise the pointer handling
> could be improved. For example,
> +    if ( (iface==0) || (ppvObject==0) )
> should at least use NULL instead of 0 as both are pointers, but !ptr is
> even better here. Accordingly

iface shouldn't generally be checked for NULL unless a program depends
on it and a testcase shows this behaviour in native.

Rob Shearman

More information about the wine-devel mailing list