d3drm: Merge Direct3DRMCreate with its implementation.

Dmitry Timoshkov dmitry at codeweavers.com
Mon Jan 11 15:44:02 CST 2010

Christian Costa <titan.costa at wanadoo.fr> wrote:

> What the hell is the purpose of this patch ?

Isn't the subject clear enough? Please calm down.

> d3drm.c is for the IDirect3DRMx objects implementations and there will 
> be a file for each other object.

Once it's really needed you can create as much source files as you prefer.

> Direct3DRMCreate is just an entry point and BTW many wine DirectX dlls 
> are implemented this way because
> some objects can be also created using the class factory.

So far that's not needed.

> And why are you removing the d3drm_private.h file at all ?

Because it's not needed.

> More generally, is it really necessary to do some clean-up while I'm 
> doing some work on this dll ?

There is no need to quote the whole patch if you aren't going to comment on
it anyway.


More information about the wine-devel mailing list