Nikolay Sivov : advapi32: Free descriptor if it isn' t returned from GetSecurityInfo().
Rob Shearman
robertshearman at gmail.com
Tue Jan 12 04:45:37 CST 2010
2010/1/11 Alexandre Julliard <julliard at winehq.org>:
> Module: wine
> Branch: master
> Commit: dbd76575ef8353484afa0b0d2da95760c26f34fe
> URL: http://source.winehq.org/git/wine.git/?a=commit;h=dbd76575ef8353484afa0b0d2da95760c26f34fe
>
> Author: Nikolay Sivov <bunglehead at gmail.com>
> Date: Fri Jan 8 21:05:21 2010 +0300
>
> advapi32: Free descriptor if it isn't returned from GetSecurityInfo().
>
> ---
>
> dlls/advapi32/security.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c
> index 629a74a..babe468 100644
> --- a/dlls/advapi32/security.c
> +++ b/dlls/advapi32/security.c
> @@ -3118,6 +3118,8 @@ DWORD WINAPI GetSecurityInfo(
> }
> if (ppSecurityDescriptor)
> *ppSecurityDescriptor = sd;
> + else
> + LocalFree(sd);
>
> return ERROR_SUCCESS;
> }
This is not correct as per the discussion on wine-devel, so it needs
to be reverted. It causes these new Valgrind warnings:
http://kegel.com/wine/valgrind/logs/2010-01-11-14.17/diff-advapi32_security.txt
--
Rob Shearman
More information about the wine-devel
mailing list