[PATCH 4/5] xmllite/tests: Add basic test structure for IXmlReader
bunglehead at gmail.com
Fri Jan 22 02:29:56 CST 2010
On 1/22/2010 11:20, Paul Vriens wrote:
> On 01/21/2010 07:20 PM, Reece Dunn wrote:
>> Hmmm. According to
>> http://msdn.microsoft.com/en-us/magazine/cc163436.aspx, this should
>> work (but then msdn isn't always right).
>> Do you know what happens if the CoGetMalloc/IMalloc_DidAlloc call is
>> not made?
> If I leave this out the test doesn't crash.
Feel free to remove it.
>> Shouldn't the IMalloc object be released?
> I thought it was just a pointer?
There's nothing to release. It's a static global pointer.
> I'm not sure what the intention for this piece of code was btw. Was it
> to prove what allocated the memory (or rather what didn't)?
I was to check that reader isn't allocated with default IMalloc - MSDN
tells that passing NULL for imalloc parameter will use default
IMalloc. For now we could remove this test out to stop crash cause
xmllite is empty yet and more tests for this allocator are needed further.
More information about the wine-devel