[PATCH 1/2] user32/tests/win.c: Fix Win9x detection

Michael Karcher wine at mkarcher.dialup.fu-berlin.de
Mon Jan 25 02:37:02 CST 2010

Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov:
> > The current code misdetects both Windows XP and Wine as Win9x and skips
> > some tests due to this. The SetParent tests were not passing on XP, so
> > this patch also removes the tests that fail on XP SP3.
> These should be 2 separate patches.
> And according to
> http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_XP.html#user32:win
> SetParent tests pass under XP just fine.

No, they don't pass on Windows XP. But they also don't fail on Windows
XP, because they are not run at all, because the Win9x detection is

If I make two separate patches out of it, we either have a no-op-patch
(changing tests that are not run), or we have an interim version that
fails tests on Windows XP. no-op-patches won't help in bisecting, as you
will always bisect to the enabling patch, and I used to think that
interim versions that fail tests are frowned upon.

Thank you for looking at the patch nevertheless,
  Michael Karcher

More information about the wine-devel mailing list