[PATCH 1/2] user32/tests/win.c: Fix Win9x detection

Dmitry Timoshkov dmitry at codeweavers.com
Mon Jan 25 03:30:50 CST 2010

Michael Karcher <wine at mkarcher.dialup.fu-berlin.de> wrote:

> > And according to
> > http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_XP.html#user32:win
> > SetParent tests pass under XP just fine.
> No, they don't pass on Windows XP. But they also don't fail on Windows
> XP, because they are not run at all, because the Win9x detection is
> wrong.

Since it's me who have written these tests in 2005 I'm pretty sure that
the tests were passing at that time. And since I create the tests under
XP and only before sending do test them under Win98 I have added broken
is_win9x check once I noticed Win98 crashing in that test. So, broken
win9x check was added after the test has been tested under XP. This needs
retesting under different Windows versions before removing the tests.
I'd recommend to fix the broken is_win9x check first, and watch
test.winehq.org for awhile for results.


More information about the wine-devel mailing list