[PATCH 1/2] user32/tests/win.c: Fix Win9x detection

Michael Karcher wine at mkarcher.dialup.fu-berlin.de
Mon Jan 25 06:03:59 CST 2010

Am Montag, den 25.01.2010, 12:49 +0100 schrieb Paul Vriens:
> > It shows only lines 3236 to 3250 being run - these are the tests that
> > are not protected by the broken is_win9x check.
> So are all these checks broken according to you or just specific ones?

The patch that started this thread contained a patch that removes the
SetParent calls that failed on my XP SP3 system but were supposed to
work, as behaviour seems to be inconsistent on these calls. I adjusted
the expectation in the check_parent calls to that what you get if you
omit the problematic SetParent calls.

> > The interesting tests this patch touches and I claim
> >   (a) not to be run
> > and
> >   (b) failing on some systems like my XP SP3 box
> > are in lines 3254 to 3260 and the following check_parents calls.
> Is the report of your box on test.winehq.org?
No, my box is not on test.winehq.org, but as the broken tests are not
run by the currently provided binaries (because of the also broken win9x
checks), it wouldn't help.

  Michael Karcher

More information about the wine-devel mailing list