[PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)
misha680 at gmail.com
Thu Jul 8 09:54:21 CDT 2010
On Wed, Jul 7, 2010 at 10:41 PM, James McKenzie
<jjmckenzie51 at earthlink.net> wrote:
> Misha Koshelev wrote:
>>> Misha Koshelev <misha680 at gmail.com> wrote:
>>>> Ok per Dan's comments back to <last as this looks nicer.
>>> Alexandre rejects 'white space' changes, that is changes that fix
>>> indentation, remove extraneous or trailing spaces and tabs unless there is
>>> another change needed. If there is a needed change in this file, go ahead
>>> and fixup white space around the change. Otherwise, hold onto this change
>>> in case you need to use it in the future.
>>> Your other change was accepted by Alexandre and was committed.
>>> James McKenzie
>> Thanks James and I appreciate the style advice.
>> Hope I didn't start anything too bitter about coding styles ;)
>> Remember we're all on the same page - making a great product even greater!
>> (Ok enough silly cheery attitude now).
> My point is that we should use the same coding style and that should use
> best practices for coding. Yes, I don't know it all and yes I get my hand
> slapped, but I am trying to improve things as well.
> Yes, progress is being made on several of the programs that I want to
> incorporate into Wine. And yes, I will go over the code for best practices
> as well. Some of the code I built was from others and some was just quickly
> written and is sloppy. Clean code is maintainable, sloppy code is not.
> The idea is to keep on moving in a linear direction, forward. We are
> chasing a big monster, the Windows 32 and Windows 64 APIs and I would like
> to think that we are making great strides forward.
> If you have language skills as well as coding skills, you might want to look
> at our translations page and see if you can start/assist with our
> translation effort as well. Lots to do here.
> James McKenzie
Thanks James. I appreciate your explanation and agree that one
(optimal) coding style for Wine would be ideal... now if only we could
agree on one ;)
As for translation skills... I _am_ fluent in Russian. However, I left
when I was nine. Thus, I'm afraid my translations would probably make
more sense to a 3rd
grader than to most Wine users, so I'll prob stick to coding for now. ;)
Plus, I see from the names on the list that there are quite a few
other Russian speakers here who are (I assume) have a much better
vocabulary than I do.
More information about the wine-devel