[PATCH] Fix EndDialog behaviour for OrCad.

Dan Kegel dank at kegel.com
Thu Jul 8 22:29:00 CDT 2010

On Thu, Jul 8, 2010 at 7:50 PM, Eliot Blennerhassett
<eblennerhassett at audioscience.com> wrote:
>> It seems your editor stripped whitespace from the ends of lines,
> Having one's editor take care of trailing whitespace is fairly standard
> practice isn't it?

Not when working on Wine code.

> Can I guess that having trailing whitespace in my new code would also be
> frowned upon?


> If you are saying they won't accept a patch because of this, I'd be
> tempted to say "for f**ks sake can I be bothered with such pettiness?",
> but I suppose "for the greater good" I'd resubmit.

The smaller the patches, the easier they are to review.  And anything we
can do to make the maintainer's life easy is a good thing.

> BTW do patches get *rejected* or just *ignored*, and is there a way to
> tell the difference?

See http://wiki.winehq.org/SubmittingPatches for the link to the patch
status page;
patches are either rejected or deferred, but they don't get ignored.

>> You might have better luck getting your change in if you include a test.
> I have absolutely no idea how to or what to test

Can you come up with a small C program that fails without the patch?
- Dan

More information about the wine-devel mailing list