[PATCH] Fix EndDialog behaviour for OrCad.

Eliot Blennerhassett eblennerhassett at audioscience.com
Thu Jul 8 21:50:02 CDT 2010

Hi Dan,

thanks for your response.

On 09/07/10 14:22, Dan Kegel wrote:
> Thanks for sending that patch.
> It seems your editor stripped whitespace from the ends of lines,

Having one's editor take care of trailing whitespace is fairly standard
practice isn't it?

Can I guess that having trailing whitespace in my new code would also be
frowned upon?

> causing three whitespace-only hunks on the end of your patch.
> Please don't do that; Wine developers frown on unrelated whitespace changes.

I'm not worried about people "frowning" at me.

If you are saying they won't accept a patch because of this, I'd be
tempted to say "for f**ks sake can I be bothered with such pettiness?",
but I suppose "for the greater good" I'd resubmit.

BTW do patches get *rejected* or just *ignored*, and is there a way to
tell the difference?

> You might have better luck getting your change in if you include a test.

I have absolutely no idea how to or what to test, other than to say
OrCad works with this patch, doesn't work without,
and AFAIK the patch doesn't make any existing test fail.
These existing tests include dialogs that call EndDialog from their
dialog proc.

Without help from knowledgeable wine developers I have no chance of
doing this correctly, and so far I have found interactions on the IRC
channel singularly unhelpful.

> Even then, we're in code freeze, your fix might have to wait until 1.2
> is released.


Eliot Blennerhassett
AudioScience Inc.

More information about the wine-devel mailing list