please don't shoot from the hip ;)
jjmckenzie51 at earthlink.net
Fri Jul 9 21:15:07 CDT 2010
Misha Koshelev wrote:
> Hi Guys:
> I really appreciate all the responses to my work on this bug
Not everyone gets or reads the wine-devel mailing list. It is good to
duplicate what appears in the mailing list into the bug report that it
affects. Don't expect folks to change.
However, if someone is being rude or obnoxious, please feel free to let
I'll be the first to bite on this: Please be friendly. I know that
I've been a little uptight the last few days, but it all over how we
code and what we code. Remember, folks are not going to figure out what
you were doing when trying to fix a bug six months from now that was
inadvertantly caused by bad coding practices. Look over your code
before submitting it. Look for tabs instead of spaces, dangling or
unnecessary white space, use of 'obtuse' variables (i, j, k for counters
in for/do/while loops is accepted practice, count is obvious,
count_for_this_loop is unnecessary), constants on the right side of if
statements (why you ask? Try using =, | or & instead of ==, || or &&
once and see the fireworks, switch it around and you get a compiler
error "cannot change constant"). Other things like using MSDN
variables when we could/should use WINE....
Something that I've noticed is that some code is unnecessarily complex.
Simple solutions work best and are easy to maintain. Remember, you
might not be the next to touch your code.
Thank you for reading and please folks, if you want to hammer me, do it
off the list. We don't need this to degrade into a flame war.
Coding in 'c' since 1981
Former member, WINOS/2
Former member, Project Odinn.
More information about the wine-devel