please don't shoot from the hip ;)

Alexandre Julliard julliard at
Sat Jul 10 03:36:40 CDT 2010

James McKenzie <jjmckenzie51 at> writes:

> I'll be the first to bite on this:  Please be friendly.  I know that
> I've been a little uptight the last few days, but it all over how we
> code and what we code.  Remember, folks are not going to figure out
> what you were doing when trying to fix a bug six months from now that
> was inadvertantly caused by bad coding practices.  Look over your code
> before submitting it.  Look for tabs instead of spaces, dangling or
> unnecessary white space, use of 'obtuse' variables (i, j, k for
> counters in for/do/while loops is accepted practice, count is obvious,
> count_for_this_loop is unnecessary),  constants on the right side of
> if statements (why you ask?  Try using =, | or & instead of ==, || or
> && once and see the fireworks, switch it around and you get a compiler
> error "cannot change constant").

Writing if statements the wrong way around is silly and makes the code
harder to read. Don't do that. (And no, I don't care what your
programming book says on the subject).

Alexandre Julliard
julliard at

More information about the wine-devel mailing list